Here is a rough cost-benefit analysis. I found all the numbers before doing any maths and tried to be as optimistic as possible towards your theory to account for people more intelligent than me coming up with better ways to do it if it became standardised.
The cost of freezing a cell is proxied as the cost of freezing your eggs, which is already commercially available. It is £2900 for the initial harvest and £275 for a subsequent year of freezing. This £275 is not discounted because you pay it every year. Source. Let's assume that the clinic are nice and let you freeze as many different organ-cells as you want for the same £275 / year fee.
There are 56,000 people in the EU who are on the organ donor waiting list, suggesting there are around 56,000 people who have a sufficiently chronic failure of an organ that it didn't kill them outright but will kill them if they don't get a transplant. Many of these 56,000 people will get an organ through conventional means, but let's say none of them do to account for the fact that as medicine advances we will probably be able to transfer more people off the 'going to die' list onto the 'might be able to survive if given a transplant' list. Let's also assume that this represents 56,000 new people on the organ transplant list each year, even though the average wait on the list is around three years. Source (also I found a dodgy-looking source suggesting that 50,000 people die of organ failure each year, so the figure for the number who could benefit is probably not out by more than an order of magnitude). There are 500m people in the EU, so your chance of being on the organ transplant list in any given year is about 0.01%.
Same source as above suggests the average QALY gain for an organ transplant is 11.5 for a liver transplant, 6.8 for a heart transplant and 5.2 for a lung transplant. Let's assume all transplants give you the full 11.5 QALYs because medicine improves.
Finally let's assume you freeze your cells now at 25 with the expectation that they will be used in 40 years at 65. You only get one shot at doing this; you may never freeze your cells again because they degrade too much on your 26th birthday.
This means in total you pay £13900 for a 0.01% chance at 11.5 additional QALYs, for an expectated value of £10.8m / QALY. That is to say, if you would pay £10.8m for an additional year of life at the margin, this is probably worthwhile (given some very optimistic assumptions). However, this is only true if you get one shot to freeze your cells at 25. If instead you can wait until you need them and freeze them then, you'd only be paying something like £250 / QALY. You can see from these two numbers that even if cells degrade in quality to the extent that they are a thousand times harder to successfully transplant you are still better to wait until you are pretty sure you are a high-risk group for organ failure. Anyone who believes £10.8m / QALY is a good deal should also be prepared to accept a salary cut of around £115,000 / year in order to avoid a 20 mile commute since road vehicles have a fatality rate of something like 1.5 per billion miles travelled.
Realistically, I would expect that having your own cells frozen probably brings more benefits on average than being able to get an organ donation. Organs are in short supply. If they were abundant, doctors would give them to more people, increasing your p given above.
Still, if organs were free and 100% immunocompatible, many things would still be a problem. E.g. cancer.
Past and Present
Ten years ago teenager me was hopeful. And stupid.
The world neglected aging as a disease, Aubrey had barely started spreading memes, to the point it was worth it for him to let me work remotely to help with Metuselah foundation. They had not even received that initial 1,000,000 donation from an anonymous donor. The Metuselah prize was running for less than 400,000 if I remember well. Still, I was a believer.
Now we live in the age of Larry Page's Calico, 100,000,000 dollars trying to tackle the problem, besides many other amazing initiatives, from the research paid for by Life Extension Foundation and Bill Faloon, to scholars in top universities like Steve Garan and Kenneth Hayworth fixing things from our models of aging to plastination techniques. Yet, I am much more skeptical now.
Individual risk
I am skeptical because I could not find a single individual who already used a simple technique that could certainly save you many years of healthy life. I could not even find a single individual who looked into it and decided it wasn't worth it, or was too pricy, or something of that sort.
That technique is freezing some of your cells now.
Freezing cells is not a far future hope, this is something that already exists, and has been possible for decades. The reason you would want to freeze them, in case you haven't thought of it, is that they are getting older every day, so the ones you have now are the youngest ones you'll ever be able to use.
Using these cells to create new organs is not something that may help you if medicine and technology continue progressing according to the law of accelerating returns in 10 or 30 years. We already know how to make organs out of your cells. Right now. Some organs live longer, some shorter, but it can be done - for instance to bladders - and is being done.
Hope versus Reason
Now, you'd think if there was an almost non-invasive technique already shown to work in humans that can preserve many years of your life and involves only a few trivial inconveniences - compared to changing diet or exercising for instance- the whole longevist/immortalist crowd would be lining up for it and keeping back up tissue samples all over the place.
Well I've asked them. I've asked some of the adamant researchers, and I've asked the superwealthy; I've asked the cryonicists and supplement gorgers; I've asked those who work on this 8 hour a day every day, and I've asked those who pay others to do so. I asked it mostly for selfish reasons, I saw the TEDs by Juan Enriquez and Anthony Atala and thought: hey look, clearly beneficial expected life length increase, yay! let me call someone who found this out before me - anyone, I'm probably the last one, silly me - and fix this.
I've asked them all, and I have nothing to show for it.
My takeaway lesson is: whatever it is that other people are doing to solve their own impending death, they are far from doing it rationally, and maybe most of the money and psychology involved in this whole business is about buying hope, not about staring into the void and finding out the best ways of dodging it. Maybe people are not in fact going to go all-in if the opportunity comes.
How to fix this?
Let me disclose first that I have no idea how to fix this problem. I don't mean the problem of getting all longevists to freeze their cells, I mean the problem of getting them to take information from the world of science and biomedicine and applying it to themselves. To become users of the technology they are boasters of. To behave rationally in a CFAR or even homo economicus sense.
I was hoping for a grandiose idea in this last paragraph, but it didn't come. I'll go with a quote from this emotional song sung by us during last year's Secular Solstice celebration