Assuming that cryonics has a decent chance of working, then the question boils down to what you will actually be spending your money on if not cryonics. There is no point in saving the money that would be spend on cryonics, and instead spending it on vacations to the tropics or something.
Will sacrificing vacation time, or starbucks visits, or high-speed internet, or something similar for cryonics deplete a pool of willpower that would otherwise all be spent on fighting malaria? Will the knowledge that you're risking your life to fight malaria more effectively make you feel more altruistic, and satisfy your appetite for altruism faster than just donating non-life-saving money to fight malaria, and therefore make you donate less money to fighting malaria overall?
I am not currently signed up for cryonics. I am considering it, but have not yet decided whether it is the right choice. Here's my reasoning.
I am very sure of the following:
1. Life is better than death. For any given finite lifespan, I'd prefer a longer one, at least within the bounds of numbers I can reasonably contemplate.
2. Signing up for cyronics increases the expected value of my lifespan.
But then I also believe the following:
3. I am not particularly exceptional among the set of human beings, and so should not value my lifespan much more than that of other humans. I obviously fail at this in practice, but I think the world would be a much better place if I and others didn't fail so often.
4. The money it would take to sign up for cryonics, though not large, is enough to buy several centuries of healthy life each year if given to givewell's top malaria charities. Since on average I expect to live another 50-60 years without cryonics, the investment would need to increase the expected value of my lifespan by at least 5,000 years at minimum to be morally acceptable to me.
5. There is a chance we'll discover immortality in my lifetime. If so, then if I signed up for cryonics the payout is 0, and the people who died because I bought insurance instead of charity are people I could have saved for far longer.
So, what do you think is the probability that immortality will be discovered in my lifetime? What about the probability that, if signed up for cryonics, I will live into the far future? These priors would seem to be the key for me to decide whether signing up for cryonics is morally acceptable to me.