The problem with this hypothesis is that it has Snape thinking that student crushes on teachers are persistent sorts of things, and this isn't typically the case.

Well, he could well be generalizing from one example...